Feat path evaluation #162
Open
Feat path evaluation #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…integrated in base_page_object.py
…ct_by_path of base_page_object.py in order to get a list with more than one element if exist in the path. The rest of files have been changed to make a get-config test that try the issue .
josemtnzjmnz
requested review from
sbarguil,
alfredogonzalezmuniz,
javierb10,
vlopezalvarez and
oscargdd
josemtnzjmnz
added
enhancement
sbarguil
requested changes
Feb 25, 2021
…ded in get_tag_value_in_given_dict_by_path method of base_page_object.py file.
sbarguil
approved these changes
Mar 1, 2021
| for i in range(0, len(parsed_dict)): | ||
| subdict = parsed_dict[i] | ||
| if path[0] in subdict: | ||
| return_result = self.get_tag_value_in_given_dict_by_path(auxiliar_output_list,path=path, parsed_dict=subdict[path[0]]) |
| @@ -240,11 +280,15 @@ def validate_get_test_case(self): | |||
| print(self.values_after_get) | |||
| test_passes = True | |||
| for key, value in self.values_after_get.items(): | |||
| if not self.values_after_get[key]: | |||
| if not self.values_after_get[key]: #Check if some of the elements of values_after_get[key] is zero, empty, False or None | |||
| dict_variables_to_commit = self.generic_variables_to_commit[0] | ||
| dict_variables_to_commit.pop('value_to_commit') | ||
| variables_to_search=dict_variables_to_commit | ||
| list_path_eval = self.get_tag_value_in_given_dict_by_path([],path=variables_to_search['path_list'], parsed_dict=parsed_dict) |
| path=variable['path_list']), | ||
| 'path_string': variable['path_string'], | ||
| 'path_list': variable['path_list'], | ||
| } | ||
| self.generic_values_before_commit.append(new_variable) | ||
|
|
||
| def get_tag_value_in_given_dict_by_path(self, path, parsed_dict): | ||
| def get_unique_tag_value_in_given_dict_by_path(self, path, parsed_dict): |
There was a problem hiding this comment.
Method definitions inside a class are surrounded by a single blank line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #99 solved, please review the modifications in the code before accepting the pull request. When this is accepted, an automatic merge will be done in develop.