Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to interoperate with personal portfolio #7

Merged
merged 8 commits into from
Mar 31, 2024

Conversation

sayandcode
Copy link
Owner

What?

  • Added application screenshots and logo
  • Updated README (includes pictures as well)
  • Fixed minor bugs found
    • Obscured exposed secrets in .env.sample
    • Fixed bugs in deployment script (lack of ci flag)
    • Fixed typos in .env.sample file name
    • Fixed viewport height glitching bug
  • Updated developer README docs, for easily extending the project in the future (if necessary)

Why?

This helps us showcase this project on my portfolio

How?

The README files were updated as per the format required by my personal portfolio

This is following the format expected by my [portfolio](https://github.com/sayandcode/portfolio/tree/feature/v2)
i.e. with numbered screenshots accompanied by a _count.txt_ file serving
as an index
The pictures used were also added to the documentation folder
Earlier we had sample values in .env.sample files. This is largely
redundant due to the run-time typechecks and the associated schema
definitions. Devs can just look at the schema definitions for the .env
files, to understand what the data looks like. They don't need sample
data
Earlier we were not using the dedicated CI-deployment script. This prevents
failures in case of prompts by the CLI to confirm deployment, by accepting
all prompts.
- The screenshot is now a full-width image with no visible alpha component.

- The README now centers the embedded twitter post

- The code snippet is wrapped around the line

- The system diagram is made clickable for viewing in a separate tab
Using dvh causes a small amount of jittering when the address bar shrinks
when the user scrolls. This can be perceived as a bug. To avoid this
perception, we use small viewport height (svh) instead, so that user
gets the full experience (full screen) even when the address bar is shown
@sayandcode sayandcode merged commit a9d80c1 into main Mar 31, 2024
2 checks passed
@sayandcode sayandcode deleted the docs/personal-portfolio-interop branch April 13, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant