Fix address conflicts in FinthetixStakingContract tests
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests In our tests we now make sure that the randomly generated addresses don't conflict with the address of the staking contract and associated tokens. We also make sure that if there are multiple addresses being used inside the test, that those don't overlap as well. This bug in the tests were making the fuzz tests fail occasionally, since there's only a small chance that the randomly generated addresses overlap
For some of the tests we don't fuzz for random addresses, but rather use static addresses to impersonate a user. However, we never considered the fact that these addresses could conflict with the `Finthetix` addresses as well. So in order to make sure this is not the case, we explicitly check this in the `setup()` function. The addresses of the `Finthetix` contracts depend on some random seed. So we can trust that for a given condition of the codebase, the addresses will be consistent. Hence we are okay with explicitly failing these tests in case there is a conflict, since in such a condition we can manually alter these burner addresses (effectively changing the seed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In our tests we now make sure that the randomly generated addresses don't conflict with the address of the staking contract and associated tokens. We also make sure that if there are multiple addresses being used inside the test, that those don't overlap as well.
Why?
This bug in the tests were making the fuzz tests fail occasionally. They fail rarely since there's only a small chance that the randomly generated addresses overlap.
How?
We added a test helper function
_assumeAddressDoesntConflictWithFinthetix, which makes sure the address passed in doesn't conflict with the Finthetix reserved addresses