Skip to content

Commit

Permalink
ci: Fix config bugs in deployment and QC pipelines
Browse files Browse the repository at this point in the history
- Node is now explicitly setup up with explicit versioning

- AWS login is configured for the deployment step
  • Loading branch information
sayandcode committed Mar 29, 2024
1 parent 9bfc0ee commit e5f5439
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/deploy-web-app.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Deploy Web app and Infrastructure
on: workflow_dispatch

permissions:
id-token: write
contents: read

jobs:
main:
runs-on: ubuntu-20.04
Expand All @@ -9,12 +13,24 @@ jobs:
with:
submodules: recursive

- name: Setup Node v20.10
uses: actions/setup-node@v4
with:
node-version: 20.10

# We need foundry for contract types
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly

- name: Setup AWS credentials
uses: aws-actions/configure-aws-credentials@v2
with:
aws-region: ap-south-1
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
role-session-name: FinthetixDeploymentSession

- name: Install node dependencies
run: |
cd web-app/infra
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/quality-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ jobs:
with:
version: nightly

- name: Setup Node v20.10
uses: actions/setup-node@v4
with:
node-version: 20.10

- name: Install node dependencies
run: |
cd web-app/infra
Expand Down

0 comments on commit e5f5439

Please sign in to comment.