Pass the provided Savon/custom logger to Faraday #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Savon logger isn't passed to Faraday, it builds a new logger to $stdout and logs to it. This results in stdout logging whenever `log: true` is set as a savon option, instead of logging to a file or so. Passing the Savon/custom logger to Faraday avoids the creation of a second logger object by Faraday and allows to capture all logs to a user provided Logger object. This patch also removes the `level` option, which is no recognized Faraday option. There is the option `log_level` only, which determines which log level which the messages are flagged by Faraday. In contrast the `log_level` option of Savon determines the minimum level of logs, which are captured by the logger.
olleolleolle
approved these changes
Nov 14, 2024
|
thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
A bugfix for savon-3.0.0.rc1
Did you add tests for your changes?
I modified already present tests.
Summary of changes
If the Savon logger isn't passed to Faraday, it builds a new logger to $stdout and logs to it. This results in stdout logging whenever
log: trueis set as a savon option, instead of logging to a file or so.Passing the Savon/custom logger to Faraday avoids the creation of a second logger object by Faraday and allows to capture all logs to a user provided Logger object.
Other information
This patch also removes the
leveloption, which is no recognized Faraday option. There is the optionlog_levelonly, which determines which log level which the messages are flagged by Faraday. In contrast thelog_leveloption of Savon determines the minimum level of logs, which are captured by the logger.