Allow to pass already configured Nori instance and not mess Nori opti…

…ons with Savon options
savonrb · Feb 22, 2021 · 7ca8292 · 7ca8292
1 parent f56393c
commit 7ca8292
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 17 deletions.
diff --git a/lib/savon/options.rb b/lib/savon/options.rb
@@ -477,9 +477,9 @@ def response_parser(parser)
       @options[:response_parser] = parser
     end
 
-    # Instruct Nori how to convert empty tags.
-    def empty_tag_value(empty_tag_value)
-      @options[:empty_tag_value] = empty_tag_value
+    # Pass already configured Nori instance.
+    def nori(nori)
+      @options[:nori] = nori
     end
 
     # Instruct Savon to create a multipart response if available.

diff --git a/lib/savon/response.rb b/lib/savon/response.rb
@@ -142,21 +142,16 @@ def xml_namespaces
     end
 
     def nori
-      return @nori if @nori
+      return @locals[:nori] if @locals[:nori]
 
-      nori_options = {
-        :delete_namespace_attributes => @globals[:delete_namespace_attributes],
-        :strip_namespaces            => @globals[:strip_namespaces],
-        :convert_tags_to             => @globals[:convert_response_tags_to],
-        :convert_attributes_to       => @globals[:convert_attributes_to],
-        :advanced_typecasting        => @locals[:advanced_typecasting],
-        :parser                      => @locals[:response_parser],
-        :empty_tag_value             => @locals[:empty_tag_value]
-      }
-
-      non_nil_nori_options = nori_options.reject { |_, value| value.nil? }
-      @nori = Nori.new(non_nil_nori_options)
+      @nori ||= Nori.new({
+                           :delete_namespace_attributes => @globals[:delete_namespace_attributes],
+                           :strip_namespaces            => @globals[:strip_namespaces],
+                           :convert_tags_to             => @globals[:convert_response_tags_to],
+                           :convert_attributes_to       => @globals[:convert_attributes_to],
+                           :advanced_typecasting        => @locals[:advanced_typecasting],
+                           :parser                      => @locals[:response_parser]
+                         }.reject { |_, value| value.nil? })
     end
-
   end
 end