Fix mutual recursion between autocue and replaygain metadata resolvers. #4246
+51
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a mutual recursion between the
autocue
andreplaygain
decoders which results in an infinite decoding loop.The proposed solution is to mark both decoders as
reentrant
and make sure to exclude allreentrant
decoders when implementing decoders that rely on request resolution.Fixes: #4245