Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutual recursion between autocue and replaygain metadata resolvers. #4246

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

toots
Copy link
Member

@toots toots commented Dec 8, 2024

This PR fixes a mutual recursion between the autocue and replaygain decoders which results in an infinite decoding loop.

The proposed solution is to mark both decoders as reentrant and make sure to exclude all reentrant decoders when implementing decoders that rely on request resolution.

Fixes: #4245

@toots toots enabled auto-merge December 8, 2024 15:01
@toots toots added this pull request to the merge queue Dec 8, 2024
@toots toots removed this pull request from the merge queue due to a manual request Dec 8, 2024
@toots toots enabled auto-merge December 8, 2024 15:18
@toots toots disabled auto-merge December 8, 2024 15:19
@toots toots merged commit 6e83321 into main Dec 8, 2024
@toots toots deleted the fix-4245 branch December 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RID Runaway Persists with LS 2.3.0 stable
1 participant