Reimplement audioscrobbler natively (#4250)

CHANGES.md

@@ -7,6 +7,8 @@ New:
   wav dexcoder.
 - Added optional `buffer_size` parameter to `input.alsa` and
   `output.alsa` (#4243)
+- Reimplemented audioscrobbler support natively using the more
+  recent protocol (#4250)
 
 Changed:
 

doc/content/liq/radiopi.liq

@@ -128,22 +128,23 @@ interlude = single("/home/radiopi/fallback.mp3")
 # Lastfm submission
 def lastfm(m) =
   if
-    (m["type"] == "chansons")
-  then
-    if
+    m["type"] == "chansons"
+  and
+
       (
         m["canal"] == "reggae"
       or
         m["canal"] == "Jazz"
       or
         m["canal"] == "That70Sound"
       )
-    then
-      canal =
-        if (m["canal"] == "That70Sound") then "70sound" else m["canal"] end
-      user = "radiopi-" ^ canal
-      lastfm.submit(user=user, password="xXXxx", m)
-    end
+
+  then
+    canal = if (m["canal"] == "That70Sound") then "70sound" else m["canal"] end
+    username = "radiopi-" ^ canal
+    audioscrobbler.api.track.scrobble.metadata(
+      username=username, password="xXXxx", m
+    )
   end
 end
 

dune-project

@@ -83,7 +83,6 @@
     jemalloc
     ladspa
     lame
-    lastfm
     lilv
     lo
     mad
@@ -123,7 +122,6 @@
     (inotify (< 1.0))
     (ladspa (< 0.2.0))
     (lame (< 0.3.7))
-    (lastfm (< 0.3.4))
     (lo (< 0.2.0))
     (mad (< 0.5.0))
     (magic (< 0.6))

liquidsoap-core.opam

@@ -48,7 +48,6 @@ depopts: [
   "jemalloc"
   "ladspa"
   "lame"
-  "lastfm"
   "lilv"
   "lo"
   "mad"
@@ -89,7 +88,6 @@ conflicts: [
   "inotify" {< "1.0"}
   "ladspa" {< "0.2.0"}
   "lame" {< "0.3.7"}
-  "lastfm" {< "0.3.4"}
   "lo" {< "0.2.0"}
   "mad" {< "0.5.0"}
   "magic" {< "0.6"}

src/core/builtins/builtins_optionals.ml

@@ -28,7 +28,6 @@ let () =
       ("irc", Irc_option.enabled);
       ("ladspa", Ladspa_option.enabled);
       ("lame", Lame_option.enabled);
-      ("lastfm", Lastfm_option.enabled);
       ("lilv", Lilv_option.enabled);
       ("lo", Lo_option.enabled);
       ("mad", Mad_option.enabled);

src/core/dune

@@ -465,14 +465,6 @@
  (optional)
  (modules lame_encoder))
 
-(library
- (name liquidsoap_lastfm)
- (libraries lastfm liquidsoap_core)
- (library_flags -linkall)
- (wrapped false)
- (optional)
- (modules builtins_lastfm liqfm))
-
 (library
  (name liquidsoap_lilv)
  (libraries lilv liquidsoap_core)
@@ -737,7 +729,6 @@
   jemalloc_option
   ladspa_option
   lame_option
-  lastfm_option
   lilv_option
   lo_option
   mad_option
@@ -858,11 +849,6 @@
    from
    (liquidsoap_lame -> lame_option.enabled.ml)
    (-> lame_option.disabled.ml))
-  (select
-   lastfm_option.ml
-   from
-   (liquidsoap_lastfm -> lastfm_option.enabled.ml)
-   (-> lastfm_option.disabled.ml))
   (select
    lilv_option.ml
    from