Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift Package Manager Support #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ganesh623
Copy link

Hi,
Added Swift Package Manager Support. Check, If everything fine. Merge it. It's very useful for latest projects.

Thanks

@sauvikdolui
Copy link
Owner

sauvikdolui commented May 16, 2020

@Ganesh623 thanks for expressing interest in this tiny repository, did not wish that even it can cross a star count of 125. Thanks for this pull request, and I sincerely apologize for being so late to respond because of busy schedule. Yes I agree, support of SPM will help those we are not favor of installing dependencies using Cocoa Pods. There are a few issues.

Let's come to the PR

  1. I can see the changes but, I do not see them well organized also the source file (./Sources/SDStateTableView/SDStateTableView.swift) contains the template file contents.

Screenshot 2020-05-17 at 1 29 39 AM

  1. Can you try to organize the source file in such a way so that the source files are not duplicated and both cocoapod and spm can use them?
  2. As you can see there is an example project which demonstrates how to use this library using cocoapods, i guess that will also be helpful for users to quickly install and start using this library in their own projects.
  3. And finally not the least, please also update ReadMe file with a new section under installation to instruct users how to use it.

The above four are crucial for easy maintenance and ease of end-users. I hope you will agree to these points and try to update your PR accordingly. This forum answer might be helpful for you https://forums.swift.org/t/how-to-create-a-c-library-that-supports-both-cocoa-pods-and-spm/24907.

Thanks.

@sauvikdolui sauvikdolui mentioned this pull request May 17, 2020
@sauvikdolui sauvikdolui linked an issue May 17, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPM Support
3 participants