This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Updates SauceWhisk.load_first_found #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `SauceWhisk.load_first_found` to check for the `Sauce::Config` constant, instead of `Sauce`. This will help prevent against accidental collisions with `Sauce` namespaces not provided by the (deprecated) Sauce gem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
SauceWhisk.load_first_foundto check for theSauce::Configconstant,instead of
Sauce. This will help prevent against accidental collisions withSaucenamespaces not provided by the (deprecated) Sauce gem.I ran into this while grouping some of my other Sauce utility classes under the
Saucenamespace, which makes the current version of SauceWhisk think a
Sauce::Configclass exists.
Risks
Low: Increases the specificity of assumptions (that a
Sauce::Configclass exists.)