Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makepot process to include build js strings #224

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

alexiglesias31
Copy link

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Improve the flows to generate the .pot file to include the translatable strings used on Checkout Blocks.

How to test the changes in this Pull Request:

  1. Install a build of this branch.
  2. The strings on Checkout Blocks should be translated (e.g. "Proceed to Amazon")

Changelog entry

Fix - Translate strings used on Checkout Blocks.

@alexiglesias31 alexiglesias31 self-assigned this Apr 8, 2024
@alexiglesias31 alexiglesias31 requested a review from Greg36 April 8, 2024 15:24
Copy link

@Greg36 Greg36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've checked the diff on the pot file and it looks correct.

@lauramelos lauramelos merged commit 410436a into main Aug 6, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants