Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hide standard checkout button setting #218

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Remove hide standard checkout button setting #218

merged 1 commit into from
Aug 6, 2024

Conversation

alexiglesias31
Copy link

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Remove the setting "Hide standard checkout button" because it may be too intrusive.

How to test the changes in this Pull Request:

  1. Install a built of this PR.
  2. The setting "Hide standard checkout button" should not be displayed.

Changelog entry

Update - Remove the setting "Hide standard checkout button"

@alexiglesias31 alexiglesias31 self-assigned this Dec 27, 2023
dpanta94
dpanta94 approved these changes Jan 15, 2024
View reviewed changes
Copy link

@dpanta94 dpanta94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dpanta94
Copy link

Same thing with unit tests here.

@alexiglesias31 alexiglesias31 removed the request for review from Greg36 February 7, 2024 11:00
@lauramelos lauramelos merged commit daafe01 into main Aug 6, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpanta94 dpanta94 dpanta94 approved these changes

Assignees

@alexiglesias31 alexiglesias31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexiglesias31 @dpanta94 @lauramelos