Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/error when switch to paypal #217

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix/error when switch to paypal #217

merged 2 commits into from
Aug 6, 2024

Conversation

alexiglesias31
Copy link

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. Install a built of this branch.
  2. Place a subscription with a different payment method (e.g. PayPal or Stripe)
  3. User should be able to change the payment method to Amazon Pay using both express and classic gateways.

Changelog entry

Fix - Allow Subscriptions paid with a different gateway to be updated to Amazon Pay.

@alexiglesias31 alexiglesias31 self-assigned this Dec 22, 2023
dpanta94
dpanta94 approved these changes Jan 15, 2024
View reviewed changes
Copy link

@dpanta94 dpanta94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexiglesias31 alexiglesias31 removed the request for review from Greg36 February 7, 2024 11:00
@lauramelos lauramelos merged commit f163b57 into main Aug 6, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpanta94 dpanta94 dpanta94 approved these changes

Assignees

@alexiglesias31 alexiglesias31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexiglesias31 @dpanta94 @lauramelos