New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not display the separator on minicart if button should be hidden #216

Merged

lauramelos merged 1 commit into main from fix/hide-or-separator-minicart

Aug 6, 2024

alexiglesias31 commented Dec 14, 2023

All Submissions:

Does your code follow the Extendables standards?
Have you written new tests for your changes, as applicable?
Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Install a build version of this branch.
Enable the button on the mini-cart and the option Hide Button Mode.
The -- OR -- separator shouldn't be visible in the minicart.

Changelog entry

Fix - Button separator displayed on the mini-cart when it shouldn't.


          do not display the separator on minicart if button should be hidden

b9de0ed

alexiglesias31 self-assigned this

dpanta94 approved these changes

View reviewed changes

dpanta94 left a comment

LGTM!

dpanta94 commented Jan 15, 2024

Check unit tests though mate, they used to succeed

lauramelos merged commit 109f839 into main

0 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet