Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide button sort if column cannot be hidden & fix multiple filte… #69

Merged
merged 3 commits into from
Dec 27, 2024
Merged

fix: hide button sort if column cannot be hidden & fix multiple filte… #69

merged 3 commits into from
Dec 27, 2024

Conversation

ghaithsaidani
Copy link
Contributor

  • hide the hide button on sort when column is disabled for hiding
  • fix users table filter for role and status if i choose multiple filter status or roles
  • make status and role sortable on users table
    fix filter
    fix sort

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2024 •
edited
Loading

✅ Deploy Preview for shadcn-admin ready!

Name Link
🔨 Latest commit a6ba0d8
🔍 Latest deploy log https://app.netlify.com/sites/shadcn-admin/deploys/676e74113043530008ea2a09
😎 Deploy Preview https://deploy-preview-69--shadcn-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

satnaing
satnaing reviewed Dec 27, 2024
View reviewed changes
Copy link
Owner

@satnaing satnaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hide the DropdownMenuSeparator as well.

@satnaing satnaing merged commit 969b755 into satnaing:main Dec 27, 2024
5 checks passed
@satnaing
Copy link
Owner

Thanks for your contribution.

@ghaithsaidani ghaithsaidani deleted the fix/sort-filter branch December 27, 2024 10:14
@ghaithsaidani
Copy link
Contributor Author

Good job bro on the dashboard it's well structured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satnaing satnaing satnaing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghaithsaidani @satnaing