Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virustotal results to version screen #192

Merged
merged 10 commits into from
Oct 12, 2024
Merged

Add virustotal results to version screen #192

merged 10 commits into from
Oct 12, 2024

Conversation

knightzac19
Copy link
Contributor

This adds the frontend portions of satisfactorymodding/smr-api#92 so that users can see the results of virustotal scans.

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024

@knightzac19 is attempting to deploy a commit to the satisfactorymodding Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smr-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 4:00pm

@Vilsol
Copy link
Member

Vilsol commented Oct 3, 2024

Please make the table design match that of all others
image

@Vilsol
Copy link
Member

Vilsol commented Oct 3, 2024

Also please rebase on staging

@knightzac19
Copy link
Contributor Author

Please make the table design match that of all others image

@Vilsol So I used thead instead of the tbody for the header, which is why it looks different, I can switch the other two tables to thead so they look the same?

@budak7273
Copy link
Member

Please make the table design match that of all others image

@Vilsol So I used thead instead of the tbody for the header, which is why it looks different, I can switch the other two tables to thead so they look the same?

As discussed on the discord, let's go with tbody for the header

@knightzac19
Copy link
Contributor Author

@budak7273 Okay I've synced with staging, fixed a small bug I found with the table, added translatable text and moved to tbody.

@budak7273 budak7273 merged commit 1d65000 into satisfactorymodding:staging Oct 12, 2024
7 checks passed
budak7273 added a commit that referenced this pull request Jan 7, 2025
@budak7273 @knightzac19 @lmachens
Update main with changes from staging (#204)
230252e 
* feat: add more languages, fix DE flag discoloration, sml-versions redirect (#200)

* fix: language flag icons showing with incorrect colors
(ex. germany white instead of black)

* feat: add es, hu, ko, pt-BR, to language picker. widen dropdown, setup overflow scrolling

* fix: typo

* feat: redirect old /sml-versions page to /mod/SML

* Add virustotal results to version screen (#192)

* feat: added virustotal results to versions screen

* fix: remove canedit from vt results

* fix: update to virustotal_results

* fix: move thead to tbody/make text translatable

---------

Co-authored-by: Rob B <[email protected]>

* feat: add Satisfactory Interactive Map th.gl tool link (#211)

* Add Satisfactory Interactive Maps by TH.GL

* Contain images with different aspect ratio

* Prettify

---------

Co-authored-by: Zachary Knight <[email protected]>
Co-authored-by: DevLeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th3Fanbus Th3Fanbus Th3Fanbus left review comments

@Vilsol Vilsol Vilsol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Mod Repository (SMR)
Status: ✅ Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knightzac19 @Vilsol @budak7273 @Th3Fanbus