Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (PSKD-814) Default K8s version is 1.30, add support for 1.31 #310

Merged
merged 19 commits into from
Dec 3, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Nov 13, 2024

Changes:

  • Updated default Kubernetes version to 1.30 and added support for Kubernetes 1.31.
  • Updated kubectl version to 1.30.x
  • Updated the Dockerfile to download kubectl from a new location with checksum verification.

Tests:

See comment below for test details.

@dhoucgitter dhoucgitter added the enhancement New feature or request label Nov 13, 2024
@dhoucgitter dhoucgitter self-assigned this Nov 13, 2024
Signed-off-by: David.Houck <[email protected]>
@dhoucgitter
Copy link
Member Author

Scenario K8s version Postgres DB PG Database Notes
1 Provision a K8s 1.29 EKS cluster no external Postgres none successful cluster creation
2 Provision a K8s 1.30 EKS cluster external Postgres none successful cluster creation
3 Provision a K8s 1.31 EKS cluster external Postgres none successful cluster creation
4 Provision a K8s 1.30 EKS cluster external Postgres create "SharedServices" database successful cluster creation, successful deploy of Viya 4 stable 2024.11 order
5 Provision a K8s 1.31 EKS cluster external Postgres create "SharedServices" database successful cluster creation, successful deploy of Viya 4 stable 2024.11 order using Deployment Operator and kubectl version 1.31.2 override

Signed-off-by: David.Houck <[email protected]>
@dhoucgitter dhoucgitter marked this pull request as ready for review December 3, 2024 02:34
@dhoucgitter
Copy link
Member Author

In answer to a review question, the almalinux:minimal work layer was added to the Dockerfile to gain access to a shell supporting process substitution which is being used to validate the kubectl download checksum. None of the existing layers had a shell that supported the required process substitution expression. The work layer is only used for the download and checksum verification. The kubectl binary is copied out of that layer for the final image so no increase in image size overall.

Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for explaining the added work layer

@dhoucgitter dhoucgitter merged commit 758a8fe into staging Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants