Edited test_score_definitions for syntax issue

sassoftware · Aug 30, 2024 · 2ab0c9f · 2ab0c9f
1 parent 223d671
commit 2ab0c9f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/sasctl/_services/score_definitions.py b/src/sasctl/_services/score_definitions.py
@@ -75,14 +75,14 @@ def create_score_definition(
         """
 
         model = cls._model_repository.get_model(model)
-        model_id = model.id
 
         if not model:
             raise HTTPError(
                 {
                     f"This model may not exist in a project or the model may not exist at all."
                 }
             )
+        model_id = model.id
         model_project_id = model.get("projectId")
         model_project_version_id = model.get("projectVersionId")
         model_name = model.get("name")

diff --git a/tests/unit/test_score_definitions.py b/tests/unit/test_score_definitions.py
@@ -26,8 +26,9 @@
 
 
 class CustomMock:
-    def __init__(self, json_info):
+    def __init__(self, json_info,  id=""):
         self.json_info = json_info
+        self.id = id
 
     def get(self, key1, key2=None, key3=None):
         if key2 is None and key3 is None:
@@ -69,7 +70,7 @@ def test_create_score_definition():
                     with pytest.raises(HTTPError):
                         sd.create_score_definition(
                             score_def_name="test_create_sd",
-                            model_id="12345",
+                            model="12345",
                             table_name="test_table",
                         )
 
@@ -87,7 +88,7 @@ def test_create_score_definition():
                     with pytest.raises(HTTPError):
                         sd.create_score_definition(
                             score_def_name="test_create_sd",
-                            model_id="12345",
+                            model="12345",
                             table_name="test_table",
                         )
 
@@ -98,7 +99,7 @@ def test_create_score_definition():
                     with pytest.raises(HTTPError):
                         sd.create_score_definition(
                             score_def_name="test_create_sd",
-                            model_id="12345",
+                            model="12345",
                             table_name="test_table",
                             table_file="test_path",
                         )
@@ -112,7 +113,7 @@ def test_create_score_definition():
                     get_table.return_value = get_table_mock
                     response = sd.create_score_definition(
                         score_def_name="test_create_sd",
-                        model_id="12345",
+                        model="12345",
                         table_name="test_table",
                         table_file="test_path",
                     )
@@ -122,7 +123,7 @@ def test_create_score_definition():
                     get_table.return_value = get_table_mock
                     response = sd.create_score_definition(
                         score_def_name="test_create_sd",
-                        model_id="12345",
+                        model="12345",
                         table_name="test_table",
                         table_file="test_path",
                     )
@@ -146,7 +147,7 @@ def test_create_score_definition():
                     get_table.return_value = get_table_mock
                     response = sd.create_score_definition(
                         score_def_name="test_create_sd",
-                        model_id="12345",
+                        model="12345",
                         table_name="test_table",
                     )
                     assert response