Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert new calculation functions #2067

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Revert new calculation functions #2067

merged 3 commits into from
Aug 17, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Aug 17, 2023

@nex3 nex3 requested a review from Goodwine August 17, 2023 18:28
@nex3 nex3 merged commit e70cd5a into main Aug 17, 2023
45 checks passed
@nex3 nex3 deleted the revert-calc branch August 17, 2023 19:02
@stof
Copy link
Contributor

stof commented Aug 18, 2023

shouldn't this keep the new CSS functions that don't conflict with Sass functions ? Many Sass math functions are only available namespaced.

@nex3
Copy link
Contributor Author

nex3 commented Aug 18, 2023

The issue isn't built-in Sass functions, it's user-defined Sass functions. Any user could define a function named rem() (to use the most common example) which would get completely blown up by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants