Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable filter by variable name in mp filter series #369

Merged
merged 6 commits into from
Dec 31, 2023
Merged

feat: enable filter by variable name in mp filter series #369

merged 6 commits into from
Dec 31, 2023

Conversation

allanbowe
Copy link
Member

@allanbowe allanbowe commented Dec 31, 2023 •
edited
Loading

Issue

#368

https://git.datacontroller.io/dc/dc/issues/68

Intent

Enables variable names as well as values in the filter macros

Implementation

Update to filter checks

Checks

  • Code is formatted correctly (sasjs lint).
  • Any new functionality has been unit tested.
  • All unit tests are passing (sasjs test).
  • The PR desc or underlying commits follow the Conventional Commit standard

@allanbowe allanbowe linked an issue Dec 31, 2023 that may be closed by this pull request
Enable filter by variable name in mp_filter series #368
Closed
@allanbowe allanbowe merged commit 6da578e into main Dec 31, 2023
1 check passed
@allanbowe allanbowe deleted the 368-enable-filter-by-variable-name-in-mp_filter-series branch December 31, 2023 00:36
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable filter by variable name in mp_filter series
1 participant
@allanbowe