nits

Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97 · Sep 3, 2024 · abae3bb · abae3bb
1 parent 6a99cea
commit abae3bb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/modules/mapper-extras/src/main/java/org/opensearch/index/mapper/ScaledFloatFieldMapper.java b/modules/mapper-extras/src/main/java/org/opensearch/index/mapper/ScaledFloatFieldMapper.java
@@ -355,7 +355,7 @@ private double scale(Object input) {
         }
 
         @Override
-        public double toDoubleValue(Long value) {
+        public double toDoubleValue(long value) {
             double inverseScalingFactor = 1d / scalingFactor;
             return value * inverseScalingFactor;
         }

diff --git a/server/src/main/java/org/opensearch/index/mapper/FieldValueConverter.java b/server/src/main/java/org/opensearch/index/mapper/FieldValueConverter.java
@@ -20,11 +20,11 @@
 public interface FieldValueConverter {
 
     /**
-     * Converts the given long value to a double value.
+     * Converts the Lucene representation of the value as a long to an actual double representation
      *
      * @param value the long value to be converted
      * @return the corresponding double value
      */
-    double toDoubleValue(Long value);
+    double toDoubleValue(long value);
 
 }
diff --git a/server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java b/server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java
@@ -228,8 +228,8 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
-                return HalfFloatPoint.sortableShortToHalfFloat((short) value.longValue());
+            public double toDoubleValue(long value) {
+                return HalfFloatPoint.sortableShortToHalfFloat((short) value);
             }
 
             @Override
@@ -377,8 +377,8 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
-                return NumericUtils.sortableIntToFloat((int) value.longValue());
+            public double toDoubleValue(long value) {
+                return NumericUtils.sortableIntToFloat((int) value);
             }
 
             @Override
@@ -515,7 +515,7 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
+            public double toDoubleValue(long value) {
                 return NumericUtils.sortableLongToDouble(value);
             }
 
@@ -652,7 +652,7 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
+            public double toDoubleValue(long value) {
                 byte[] bytes = new byte[8];
                 NumericUtils.longToSortableBytes(value, bytes, 0);
                 return NumericUtils.sortableLongToDouble(NumericUtils.sortableBytesToLong(bytes, 0));
@@ -738,7 +738,7 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
+            public double toDoubleValue(long value) {
                 return (double) value;
             }
 
@@ -818,7 +818,7 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
+            public double toDoubleValue(long value) {
                 return (double) value;
             }
 
@@ -994,7 +994,7 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
+            public double toDoubleValue(long value) {
                 return (double) value;
             }
 
@@ -1126,7 +1126,7 @@ public byte[] encodePoint(Number value) {
             }
 
             @Override
-            public double toDoubleValue(Long value) {
+            public double toDoubleValue(long value) {
                 return Numbers.unsignedLongToDouble(value);
             }
 
@@ -1718,7 +1718,7 @@ public byte[] encodePoint(Number value) {
         }
 
         @Override
-        public double toDoubleValue(Long value) {
+        public double toDoubleValue(long value) {
             return type.toDoubleValue(value);
         }
     }