Skip to content

Commit

Permalink
Fix for #15 and #18.
Browse files Browse the repository at this point in the history
  • Loading branch information
sarbagyastha committed Dec 18, 2019
1 parent efd3a42 commit 7cc22f6
Show file tree
Hide file tree
Showing 17 changed files with 175 additions and 510 deletions.
97 changes: 95 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,100 @@
# Miscellaneous
*.class
*.lock
*.log
*.pyc
*.swp
.DS_Store
.dart_tool/
.atom/
.buildlog/
.history
.svn/

# IntelliJ related
*.iml
*.ipr
*.iws
.idea/

# Visual Studio Code related
.vscode/

# Flutter repo-specific
/bin/cache/
/bin/mingit/
/dev/benchmarks/mega_gallery/
/dev/bots/.recipe_deps
/dev/bots/android_tools/
/dev/docs/doc/
/dev/docs/flutter.docs.zip
/dev/docs/lib/
/dev/docs/pubspec.yaml
/dev/integration_tests/**/xcuserdata
/dev/integration_tests/**/Pods
/packages/flutter/coverage/
version

# packages file containing multi-root paths
.packages.generated

# Flutter/Dart/Pub related
**/doc/api/
.dart_tool/
.flutter-plugins
.packages
.pub-cache/
.pub/
build/
flutter_*.png
linked_*.ds
unlinked.ds
unlinked_spec.ds

# Android related
**/example/android/**/gradle-wrapper.jar
**/example/android/.gradle
**/example/android/captures/
**/example/android/gradlew
**/example/android/gradlew.bat
**/example/android/local.properties
**/example/android/**/GeneratedPluginRegistrant.java
**/example/android/key.properties
*.jks

# iOS/XCode related
**/example/ios/**/*.mode1v3
**/example/ios/**/*.mode2v3
**/example/ios/**/*.moved-aside
**/example/ios/**/*.pbxuser
**/example/ios/**/*.perspectivev3
**/example/ios/**/*sync/
**/example/ios/**/.sconsign.dblite
**/example/ios/**/.tags*
**/example/ios/**/.vagrant/
**/example/ios/**/DerivedData/
**/example/ios/**/Icon?
**/example/ios/**/Pods/
**/example/ios/**/.symlinks/
**/example/ios/**/profile
**/example/ios/**/xcuserdata
**/example/ios/.generated/
**/example/ios/Flutter/App.framework
**/example/ios/Flutter/Flutter.framework
**/example/ios/Flutter/Flutter.podspec
**/example/ios/Flutter/Generated.xcconfig
**/example/ios/Flutter/app.flx
**/example/ios/Flutter/app.zip
**/example/ios/Flutter/flutter_assets/
**/example/ios/Flutter/flutter_export_environment.sh
**/example/ios/ServiceDefinitions.json
**/example/ios/Runner/GeneratedPluginRegistrant.*

# Coverage
coverage/

build/
# Exceptions to above rules.
!**/ios/**/default.mode1v3
!**/ios/**/default.mode2v3
!**/ios/**/default.pbxuser
!**/ios/**/default.perspectivev3
!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
6 changes: 0 additions & 6 deletions .idea/google-java-format.xml

This file was deleted.

28 changes: 0 additions & 28 deletions .idea/libraries/Dart_SDK.xml

This file was deleted.

7 changes: 0 additions & 7 deletions .idea/libraries/Flutter_Plugins.xml

This file was deleted.

86 changes: 0 additions & 86 deletions .idea/markdown-navigator.xml

This file was deleted.

3 changes: 0 additions & 3 deletions .idea/markdown-navigator/profiles_settings.xml

This file was deleted.

7 changes: 0 additions & 7 deletions .idea/misc.xml

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/vcs.xml

This file was deleted.

4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.0.0+1
* **FIXED** Issue with scrollable views [Issue #18](https://github.com/sarbagyastha/flutter_rating_bar/issues/18).
* **FIXED** `unratedColor` not working for colors with alpha [Issue #15](https://github.com/sarbagyastha/flutter_rating_bar/issues/15).

## 3.0.0
**Breaking Changes**
This version requires `flutter >= 1.9`.
Expand Down
1 change: 1 addition & 0 deletions example/android/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
android.enableJetifier=true
android.useAndroidX=true
org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
8 changes: 0 additions & 8 deletions example/ios/Flutter/flutter_export_environment.sh

This file was deleted.

7 changes: 5 additions & 2 deletions example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ class _MyAppState extends State<MyApp> {
),
itemCount: 5,
itemSize: 50.0,
unratedColor: Colors.amber.withAlpha(50),
direction: _isVertical ? Axis.vertical : Axis.horizontal,
),
SizedBox(
Expand All @@ -106,7 +107,8 @@ class _MyAppState extends State<MyApp> {
suffixIcon: MaterialButton(
onPressed: () {
setState(() {
_userRating = double.parse(_ratingController.text ?? "0.0");
_userRating =
double.parse(_ratingController.text ?? "0.0");
});
},
child: Text("Rate"),
Expand Down Expand Up @@ -222,8 +224,9 @@ class _MyAppState extends State<MyApp> {
initialRating: 3,
direction: _isVertical ? Axis.vertical : Axis.horizontal,
allowHalfRating: true,
unratedColor: Colors.grey[200],
unratedColor: Colors.amber.withAlpha(50),
itemCount: 5,
itemSize: 50.0,
itemPadding: EdgeInsets.symmetric(horizontal: 4.0),
itemBuilder: (context, _) => Icon(
_selectedIcon ?? Icons.star,
Expand Down
Loading

0 comments on commit 7cc22f6

Please sign in to comment.