Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GemmType trait for dispatching gemm fn calls #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivarflakstad
Copy link

I was wondering if this change would be of interest.
Removes the if-else-panic and let's the type system take care of that constraint instead.

@ivarflakstad ivarflakstad changed the title Add GEMMType trait for dispatching gemm fn calls Add GemmType trait for dispatching gemm fn calls Oct 27, 2023
@sarah-quinones
Copy link
Owner

thanks for the PR! though im not really sure if i want this. having no bounds is useful for usage in generic libraries, which is where the library is meant to be used. i'd prefer to leave it up to the consumers of the library to implement such a wrapper

@ivarflakstad
Copy link
Author

Hmm I see, that's a valid point.
Still I want to emphasize that it is the exact same "bounds" as were there originally - except it was expressed through if statements.

So the only change I can see is that it will fail to build rather than panic at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants