fix(api): revert removing index import for api plugin register file #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a small change that reverted a reverted commit but which broke the ambient declaration merging of the api plugin. This change restores the api plugin to be consistent with the various other plugins and to properly export the merged types again
favna
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the index import with the merged types for the api plugin ended up decoupled from the plugin register file; without it, the client constructor will not take any configuration settings for the api plugin and the container will not have the server object. This PR restores the import to the same state as the other plugins in the repo.
The current workaround is to import both the index and register file to get the ambient declarations to be detected by TypeScript again which seems unintentional.