Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update for latest framework and pieces #513

Merged
merged 15 commits into from
Dec 5, 2023

Conversation

favna
Copy link
Member

@favna favna commented Dec 4, 2023

Important

Rebase & Merge

@favna favna requested review from vladfrangu and kyranet December 4, 2023 21:39
@favna favna self-assigned this Dec 4, 2023
@favna favna requested a review from Nytelife26 as a code owner December 4, 2023 21:58
@favna

This comment was marked as outdated.

vladfrangu
vladfrangu previously approved these changes Dec 5, 2023
@favna
Copy link
Member Author

favna commented Dec 5, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented Dec 5, 2023

Heya @favna, I've started to run the deployment workflow on this PR at 97f3b7c. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Dec 5, 2023

Hey @favna, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/plugin-api@pr-513
npm install @sapphire/plugin-editable-commands@pr-513
npm install @sapphire/plugin-hmr@pr-513
npm install @sapphire/plugin-i18next@pr-513
npm install @sapphire/plugin-logger@pr-513
npm install @sapphire/plugin-pattern-commands@pr-513
npm install @sapphire/plugin-scheduled-tasks@pr-513
npm install @sapphire/plugin-subcommands@pr-513
npm install @sapphire/plugin-utilities-store@pr-513

favna added 11 commits December 5, 2023 21:02

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
…r isn't used

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
…n case register isn't used

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
… case register isn't used

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
…case register isn't used

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
… register isn't used

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
@favna
Copy link
Member Author

favna commented Dec 5, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented Dec 5, 2023

Heya @favna, I've started to run the deployment workflow on this PR at f0e9a18. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Dec 5, 2023

Hey @favna, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/plugin-api@pr-513
npm install @sapphire/plugin-editable-commands@pr-513
npm install @sapphire/plugin-hmr@pr-513
npm install @sapphire/plugin-i18next@pr-513
npm install @sapphire/plugin-logger@pr-513
npm install @sapphire/plugin-pattern-commands@pr-513
npm install @sapphire/plugin-scheduled-tasks@pr-513
npm install @sapphire/plugin-subcommands@pr-513
npm install @sapphire/plugin-utilities-store@pr-513

favna added 2 commits December 5, 2023 21:23

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
…clean `.d.ts` file
@favna
Copy link
Member Author

favna commented Dec 5, 2023

@sapphiredev pack

@sapphiredev
Copy link

sapphiredev bot commented Dec 5, 2023

Heya @favna, I've started to run the deployment workflow on this PR at cc0467d. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Dec 5, 2023

Hey @favna, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/plugin-api@pr-513
npm install @sapphire/plugin-editable-commands@pr-513
npm install @sapphire/plugin-hmr@pr-513
npm install @sapphire/plugin-i18next@pr-513
npm install @sapphire/plugin-logger@pr-513
npm install @sapphire/plugin-pattern-commands@pr-513
npm install @sapphire/plugin-scheduled-tasks@pr-513
npm install @sapphire/plugin-subcommands@pr-513
npm install @sapphire/plugin-utilities-store@pr-513

favna added 2 commits December 5, 2023 21:43

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens

Verified

This commit was signed with the committer’s verified signature.
favna Jeroen Claassens
@favna favna enabled auto-merge (rebase) December 5, 2023 20:53
@@ -1,6 +1,8 @@
import './index';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't needed

@favna favna merged commit e11b911 into main Dec 5, 2023
7 checks passed
@favna favna deleted the fix/update-to-latest-framework branch December 5, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants