sap_swpm, sap_general_preconfigure: feat: add variables for sap_install FQCN collection name for calling roles

[marcelmamula]

Description

• Add variables for setting collection name to remove hardcode dependency.
• Affected: sap_swpm and sap_general_preconfigure for calling sap_maintain_etc_hosts

Validation

Change was tested on SLES4SAP 15 SP6 on AWS with SAP ASCS/ERS HA build.

Note

• Replaces static FQCN declaration implemented in sap_general_preconfigure: Use FQCN for import_role #827
• Avoid use of shortname (no FQCN), as discussed in PR SELinux directory relabeling, ansible-lint cleaning, and minor fixes #224 and addressed in commit c2727f2

[berndfinger]

LGTM!

[sean-freeman]

Updated the GH Issue title slightly (for easier reference in future), and added to description the history (inc. specific commit where FQCN var was added previously).

Personally I only see the need for a variable that alters the namespace of the FQCN, I do not know how many people will want to fork (into new namespace) and then also deviate from the collection name "sap_install".

[berndfinger]

Personally I only see the need for a variable that alters the namespace of the FQCN, I do not know how many people will want to fork (into new namespace) and then also deviate from the collection name "sap_install".

I had the same topic in mind while reviewing but as we already have a variable ..._system_roles_collection in some roles, I thought using the full collection name is better and easier to understand than something like sap_general_preconfigure_sap_install_namespace which we probably would have to explain in more detail.

Let's see if we will have other aspects to consider, and then change from collection to namespace.

[marcelmamula]

@berndfinger @sean-freeman This was exact reason why I added it this way - same functionality as with *_system_roles_collection.