Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_netweaver_preconfigure/SUSE: Fix for issue 868 specific to SLES4SAP15 SP6 #876

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

marcelmamula
Copy link
Contributor

Several changes were added to both sap_netweaver_preconfigure and sap_hana_preconfigure roles to resolve issue reported in #868

  • Add new var file for SLES_SAP_15.6
  • Change order for var file loading to ensure that actual version is loaded first, instead of major distribution that was used before.
    Major + Minor combination var file would be ignored without this change!
  • Update saptune version flow in sap_netweaver_preconfigure to align with changes done in sap_hana_preconfigure before.
  • Fix yes/no values in sap_netweaver_preconfigure defaults file causing linting errors.

Copy link
Member

@Wabri Wabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula merged commit 13b52c7 into sap-linuxlab:dev Oct 14, 2024
4 of 5 checks passed
@marcelmamula marcelmamula deleted the sp6 branch October 18, 2024 12:32
berndfinger added a commit to berndfinger/community.sap_install that referenced this pull request Nov 18, 2024
Solves issue sap-linuxlab#689.

Further changes in this commit:
- Add the SAP note numbers and versions in a comment before the list of
  packages in the RedHat*.yml files in vars.

- Add 'ansible_architecture' as a condition in the related installation task,
  so that there is no task failure when running on another architecture than 'x86_64'.

- Also revert back to the default of 'false' for the role variable
  'sap_netweaver_preconfigure_use_adobe_doc_services'.
  See commit 384f4d8, PR sap-linuxlab#876.

Signed-off-by: Bernd Finger <[email protected]>
rob0d pushed a commit to rob0d/community.sap_install that referenced this pull request Jan 3, 2025
Solves issue sap-linuxlab#689.

Further changes in this commit:
- Add the SAP note numbers and versions in a comment before the list of
  packages in the RedHat*.yml files in vars.

- Add 'ansible_architecture' as a condition in the related installation task,
  so that there is no task failure when running on another architecture than 'x86_64'.

- Also revert back to the default of 'false' for the role variable
  'sap_netweaver_preconfigure_use_adobe_doc_services'.
  See commit 384f4d8, PR sap-linuxlab#876.

Signed-off-by: Bernd Finger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants