Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collection: Enforce minimum ansible version 2.12, part 2 #540

Merged
merged 1 commit into from
Nov 28, 2023
Merged

collection: Enforce minimum ansible version 2.12, part 2 #540

merged 1 commit into from
Nov 28, 2023

Conversation

berndfinger
Copy link
Member

@berndfinger berndfinger commented Nov 28, 2023 •
edited
Loading

This commit adds the file meta/runtime.yml to all those roles for which it was missing:

  • sap_anydb_install_oracle
  • sap_ha_pacemaker_cluster
  • sap_hypervisor_node_preconfigure
  • sap_maintain_etc_hosts
  • sap_vm_preconfigure

Finally solves issue #507.

@berndfinger
collection: Enforce minimum ansible version 2.12, part 2
e9ae454 
This commit adds the file meta/runtime.yml to all those roles for which
it was missing.

Finally solves issue sap-linuxlab#507.
ja9fuchs
ja9fuchs approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sean-freeman
sean-freeman approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@berndfinger berndfinger merged commit 2ebea3e into sap-linuxlab:dev Nov 28, 2023
1 of 3 checks passed
@berndfinger berndfinger deleted the issue-507-part-2 branch November 28, 2023 10:34
@berndfinger berndfinger mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ja9fuchs ja9fuchs ja9fuchs approved these changes

@sean-freeman sean-freeman sean-freeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berndfinger @sean-freeman @ja9fuchs