Feat/kakao login #134
Open
Feat/kakao login #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 리팩터링 필요
- 훅 분리
- ProtectedRoute 추가 - useAccessToken 추가 - useLocalStorage 추가
josworks27
requested review from
lifeisegg123,
seobie and
EUNYUSEO
as code owners
lifeisegg123
previously approved these changes
Jul 31, 2022
Comment on lines
+10
to
+20
| export const ProtectedRoute: FC<ProtectedRouteProps> = ({ | ||
| isAllowed, | ||
| redirectTo, | ||
| children, | ||
| }) => { | ||
| if (!isAllowed) { | ||
| return <Navigate replace to={redirectTo} /> | ||
| } | ||
|
|
||
| return children | ||
| } |
There was a problem hiding this comment.
Suggested change
| export const ProtectedRoute: FC<ProtectedRouteProps> = ({ | |
| isAllowed, | |
| redirectTo, | |
| children, | |
| }) => { | |
| if (!isAllowed) { | |
| return <Navigate replace to={redirectTo} /> | |
| } | |
| return children | |
| } | |
| export const ProtectedRoute: FC<ProtectedRouteProps> = ({ | |
| isAllowed, | |
| redirectTo, | |
| element, | |
| path | |
| }) => { | |
| return ( | |
| <Route | |
| path={path} | |
| element={isAllowed ? element : <Navigate replace to={redirectTo} />} | |
| /> | |
| } |
이런 구현은 어떨까요??
사용하는 곳에서 아래처럼 쓸 수 있을 것 같아요!
<Routes>
<Route path="/" element={<MapAppContainer />} />
<Route path="/login" element={<Login />} />
<ProtectedRoute
path="/protectePath"
isAllowed={isAvailable}
redirectTo="/login"
element={
<div>Protected Page</div>
}
/>
</Routes>
Comment on lines
+32
to
+43
| const { | ||
| data: { | ||
| signIn: {accessToken, expiredAt}, | ||
| }, | ||
| } = await urqlClient | ||
| .mutation(SignInDocumnet, { | ||
| input: { | ||
| code: access_token, | ||
| type: 'KAKAO', | ||
| }, | ||
| }) | ||
| .toPromise() |
There was a problem hiding this comment.
useMutation훅 사용하지 않고 이렇게 처리하신 이유가 있을까요??? 👀👀👀
- 함수표현식으로 변경
EUNYUSEO
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Help Wanted 👀
Related Issues
Checklist ✋
{PR type}: {PR title}로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)yarn build,yarn test)