feat: Add Ferrum::Browser#close

.github/workflows/linter.yml

@@ -1,5 +1,9 @@
 name: Linter
-on: [push]
+on:
+  push:
+    branches:
+      - main
+  pull_request:
 
 jobs:
    linters:

CHANGELOG.md

@@ -3,6 +3,7 @@
 ### Added
 
 - `Ferrum::Network#wait_for_idle!` raises an error if timeout reached.
+- `Ferrum::Browser#close` closes browser gracefully issuing a CDP command, doesn't clean up ruby resources.
 
 ### Changed
 

lib/ferrum/browser.rb

@@ -211,22 +211,29 @@ def restart
     def quit
       return unless @client
 
-      begin
-        command('Browser.close')
-      rescue
-      end
-
       contexts.close_connections
 
       @client.close
       @process.stop
       @client = @process = @contexts = nil
     end
 
+    #
+    # Crashes browser.
+    #
     def crash
       command("Browser.crash")
     end
 
+    #
+    # Close browser gracefully.
+    #
+    # You should clean up resources/connections in ruby world manually, it's only a CDP command.
+    #
+    def close
+      command("Browser.close")
+    end
+
     #
     # Gets the version information from the browser.
     #

spec/browser_spec.rb

@@ -329,6 +329,21 @@
     end
   end
 
+  describe "#close" do
+    it "works after crash with explicit restart" do
+      browser.go_to
+
+      expect { browser.close }.not_to raise_error
+      sleep 2
+      expect { browser.go_to }.to raise_error(Ferrum::DeadBrowserError)
+
+      browser.restart
+      browser.go_to
+
+      expect(browser.body).to include("Hello world")
+    end
+  end
+
   describe "#version" do
     it "returns browser version information" do
       version_info = browser.version