Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the oncomplete and remove snapshot closes #263 #265

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Updates to the oncomplete and remove snapshot closes #263 #265

merged 2 commits into from
Feb 19, 2024

Conversation

DLBPointon
Copy link
Contributor

No description provided.

@DLBPointon DLBPointon self-assigned this Feb 19, 2024
@DLBPointon DLBPointon linked an issue Feb 19, 2024 that may be closed by this pull request
Multiple pipeline complete messages #263
Closed
@DLBPointon DLBPointon added this to the Release 1 milestone Feb 19, 2024
@DLBPointon DLBPointon added bug Something isn't working enhancement New feature or request labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a1820cf

+| ✅ 127 tests passed       |+
#| ❔  20 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.0.2'
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • system_exit - System.exit in WorkflowTreeval.groovy: System.exit(1) [line 17]

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-treeval_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-02-19 10:42:59

@DLBPointon DLBPointon changed the base branch from remove_duplicate_fastkcofig to galaxy_dev February 19, 2024 12:43
weaglesBio
weaglesBio approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@weaglesBio weaglesBio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the onComplete block need to be removed from treeval.nf, in addition to treeval_rapid.nf and treeval_rapid_tol.nf?

@weaglesBio
Copy link
Contributor

Does the onComplete block need to be removed from treeval.nf, in addition to treeval_rapid.nf and treeval_rapid_tol.nf?

Nevermind, read issue.

@weaglesBio weaglesBio merged commit be5bb78 into galaxy_dev Feb 19, 2024
6 checks passed
@weaglesBio weaglesBio deleted the dp24_updates branch February 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaglesBio weaglesBio weaglesBio approved these changes

@yumisims yumisims Awaiting requested review from yumisims

Assignees

@DLBPointon DLBPointon

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Release 1
Development

Successfully merging this pull request may close these issues.

Multiple pipeline complete messages
2 participants
@DLBPointon @weaglesBio