Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple pipeline complete messages #263

Closed
DLBPointon opened this issue Feb 19, 2024 · 0 comments · Fixed by #265
Closed

Multiple pipeline complete messages #263

DLBPointon opened this issue Feb 19, 2024 · 0 comments · Fixed by #265
Assignees
@DLBPointon
Labels
enhancement New feature or request
Milestone
Release 1

Comments

@DLBPointon
Copy link
Contributor

Description of feature

The issue is that we have assumed that the entry points exist in almost vacuum. But no, the workflow.onComplete is pipeline wide. So we run the pipeline on default and all instances of workflow.oncomplete get triggered. I propose we only keep this in the implicit workflow, e.g. FULL (default), in TreeVal and pipelines going forward.
@DLBPointon DLBPointon added the enhancement New feature or request label Feb 19, 2024
@DLBPointon DLBPointon added this to the Release 1 milestone Feb 19, 2024
@DLBPointon DLBPointon self-assigned this Feb 19, 2024
DLBPointon added a commit that referenced this issue Feb 19, 2024
@DLBPointon
Updates to the oncomplete and remove snapshot closes #263
36d345c
@DLBPointon DLBPointon linked a pull request Feb 19, 2024 that will close this issue
Updates to the oncomplete and remove snapshot closes #263 #265
Merged
DLBPointon added a commit that referenced this issue Feb 19, 2024
@DLBPointon
Updates to the oncomplete and remove snapshot closes #263
a1820cf
weaglesBio added a commit that referenced this issue Feb 19, 2024
@weaglesBio
Merge pull request #265 from sanger-tol/dp24_updates
be5bb78 
Updates to the oncomplete and remove snapshot closes #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DLBPointon DLBPointon

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1
Development

Successfully merging a pull request may close this issue.

Updates to the oncomplete and remove snapshot closes #263 sanger-tol/treeval
1 participant
@DLBPointon