Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2.0.1 #24

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Patch 2.0.1 #24

merged 7 commits into from
Dec 5, 2024

Conversation

tkchafin
Copy link
Contributor

@tkchafin tkchafin commented Dec 5, 2024

  • changelog update
  • anaconda purge
  • version bump

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin tkchafin requested a review from muffato December 5, 2024 10:00
Copy link

github-actions bot commented Dec 5, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 70a0e26

+| ✅ 129 tests passed       |+
#| ❔  23 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: assets/nf-core-insdcdownload_logo_light.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: docs/images/nf-core-insdcdownload_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-insdcdownload_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-insdcdownload_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-insdcdownload_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-insdcdownload_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/insdcdownload/insdcdownload/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-12-05 15:13:25

CHANGELOG.md Outdated Show resolved Hide resolved
@muffato
Copy link
Member

muffato commented Dec 5, 2024

The CI may work if we switch to nf-core/setup-nextflow@v2 but I suggest we tackle that in another PR (together with the template update)

@tkchafin tkchafin merged commit bc958b7 into main Dec 5, 2024
5 of 7 checks passed
@tkchafin tkchafin deleted the patch branch December 5, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants