Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anaconda purge #23

Merged
merged 4 commits into from
Dec 5, 2024
Merged

anaconda purge #23

merged 4 commits into from
Dec 5, 2024

Conversation

tkchafin
Copy link
Contributor

@tkchafin tkchafin commented Dec 2, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin tkchafin requested a review from muffato December 2, 2024 18:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @tkchafin,

It looks like this pull-request is has been made against the tkchafin/insdcdownload main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the tkchafin/insdcdownload dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@tkchafin tkchafin changed the base branch from main to dev December 2, 2024 18:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6eba2b4

+| ✅ 129 tests passed       |+
#| ❔  23 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: assets/nf-core-insdcdownload_logo_light.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: docs/images/nf-core-insdcdownload_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-insdcdownload_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-insdcdownload_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-insdcdownload_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-insdcdownload_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/insdcdownload/insdcdownload/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-12-05 09:59:06

@muffato
Copy link
Member

muffato commented Dec 4, 2024

It looks all good to me.

I think this should go as a patch release (2.0.1) directly. It means:

  • to make the PR process easier, push your code as a branch named patch in the sanger-tol repository and make a PR directly onto main. The CI expects that scenario
  • bump the version up in the various files and add a changelog entry

@muffato muffato mentioned this pull request Dec 4, 2024
Merged
9 tasks
@tkchafin tkchafin changed the base branch from dev to patch December 5, 2024 09:50
@tkchafin tkchafin merged commit 9caccaf into sanger-tol:patch Dec 5, 2024
4 of 6 checks passed
@tkchafin tkchafin deleted the anaconda_purge branch December 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffato muffato Awaiting requested review from muffato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkchafin @muffato