-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prod release v0.2.0 #85
Conversation
change uniprot database names Co-authored-by: Priyanka Surana <[email protected]>
Co-authored-by: Priyanka Surana <[email protected]>
@gq1 Can you please take a look at the tests for this pipeline? Thanks. |
Can you run the test locally? Not much help from the log, run out of disk space?
|
I looked at These seem fine:
These seem weird:
|
e8a4d6f
to
16d200d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR on principle, pending sorting out the BUSCO JSON files and the if
statement
BLASTN_TAXON.out.txt | ||
| map { meta, txt -> txt.isEmpty() } | ||
| set { is_txt_empty } | ||
|
||
// repeat the blastn search without excluding taxon_id | ||
if ( is_txt_empty ) { | ||
BLAST_BLASTN ( BLOBTOOLKIT_CHUNK.out.chunks, blastn, [] ) | ||
ch_blastn_txt = BLAST_BLASTN.out.txt | ||
} | ||
else { | ||
ch_blastn_txt = BLASTN_TAXON.out.txt | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you're on it, but for the record: please check that the if
is working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried branching and filtering but with no better results so leaving as is for now. This might be a fix for the next version.
Python linting (
|
This is fixed. |
This is a bit long and messy. I am running a full test here:
/lustre/scratch123/tol/teams/tolit/users/ps22/pipelines/blobtoolkit
. Will update once it completes, but please start reviewing if you can. Would be great to get it merged this week. Thanks :)