Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bugfixes #103

Merged
merged 7 commits into from
Jul 18, 2024
Merged

More bugfixes #103

merged 7 commits into from
Jul 18, 2024

Conversation

muffato
Copy link
Member

@muffato muffato commented Jul 10, 2024

Last set of bugfixes before the v0.5 release

  • Added the missing "megablast" parameter
  • Added the missing --taxon-exclude in Diamond blast searches
  • Ignore warnings that the requested taxon id is not in the NT database
  • Increased resources for blastn, now following this model
Attempt CPUs Memory Maximum runtime Queue (Sanger)
1 6 1 GB 10h normal
2 5 4 GB 40h long
3 4 16 GB 160h week
4 3 64 GB 640h basement
5 2 256 GB 2,560h basement

(the number of CPUs decreases because long-running jobs are typically stuck on a sequence and don't use more than 150% CPU on average.)

I've tested the branch on the three genomes from TOLIT-2257 in /lustre/scratch123/tol/teams/tolit/users/mm49/nextflow/btk/prod

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato muffato self-assigned this Jul 10, 2024
@muffato muffato added bug Something isn't working enhancement Improvement of the existing features labels Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b83f05c

+| ✅ 133 tests passed       |+
#| ❔  24 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml
  • template_strings - template_strings
  • merge_markers - merge_markers

✅ Tests passed:

Run details

  • nf-core/tools version 2.11
  • Run at 2024-07-15 08:24:58

@muffato muffato mentioned this pull request Jul 10, 2024
10 tasks
@muffato muffato requested a review from BethYates July 15, 2024 08:35
@muffato muffato merged commit 5420de2 into dev Jul 18, 2024
6 checks passed
@muffato muffato deleted the more_bugfixes branch July 18, 2024 17:08
@muffato muffato mentioned this pull request Aug 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improvement of the existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants