Skip to content

Commit

Permalink
add validation version to sts output filename
Browse files Browse the repository at this point in the history
  • Loading branch information
amakunin committed Feb 9, 2023
1 parent fed5c71 commit 384a373
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions work/validate_bioscan.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"outputs": [],
"source": [
"def validate_bioscan(fn, gal='Sanger Institute', template_fn='../data/BIOSCAN_Manifest_V2.0_20221017.xlsx', \n",
" verbose=False, version='2.0', \n",
" verbose=False, bioscan_version='2.0', validation_version='0.1.0',\n",
" samples_sheet='TAB 2 Metadata Entry', contrib_sheet='TAB 1 Contributors', write_sts=True):\n",
" '''\n",
" BIOSCAN partner manifest validation\n",
Expand All @@ -28,7 +28,7 @@
"\n",
" setup_logging(verbose=verbose)\n",
"\n",
" logging.info(f'# started validate_bioscan_partner_manifest_v.{version}')\n",
" logging.info(f'# started validate_bioscan_partner_manifest_v.{bioscan_version}')\n",
" logging.warning(f'# manifest {fn}')\n",
"\n",
" # read data\n",
Expand Down Expand Up @@ -93,9 +93,9 @@
" \n",
" df = add_sts_cols(df, contrib_df, gal=gal)\n",
" if write_sts:\n",
" write_sts_manifest(df, fn)\n",
" write_sts_manifest(df, fn, validation_version)\n",
" \n",
" logging.info('# ended validate_bioscan_partner_manifest_v.{}'.format(version))\n",
" logging.info('# ended validate_bioscan_partner_manifest_v.{}'.format(bioscan_version))\n",
"\n",
" return df\n",
"\n",
Expand Down
4 changes: 2 additions & 2 deletions work/validate_partner_manifest_dev.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -973,9 +973,9 @@
"metadata": {},
"outputs": [],
"source": [
"def write_sts_manifest(df, input_fn):\n",
"def write_sts_manifest(df, input_fn, validation_version):\n",
" \n",
" output_fn = input_fn.rstrip('.xlsx') + '_for_sts.xlsx'\n",
" output_fn = input_fn.rstrip('.xlsx') + '_' + validation_version + '_for_sts.xlsx'\n",
" \n",
" logging.info(f'writing STS manifest to {output_fn}')\n",
" \n",
Expand Down

0 comments on commit 384a373

Please sign in to comment.