Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: make it possible to redirect to an url provided by a get param #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kabarakh
Copy link

@kabarakh kabarakh commented Apr 9, 2018

You can use this to forward to the referrer of the login form

@kabarakh kabarakh force-pushed the feature/redirectToUrlByUrlArgument branch 2 times, most recently from cb586b9 to ce4e2c6 Compare April 9, 2018 11:35
You can use this to forward to the referrer of the login form
@kabarakh kabarakh force-pushed the feature/redirectToUrlByUrlArgument branch from ce4e2c6 to a3de56d Compare April 16, 2018 08:09
@daniellienert
Copy link
Contributor

Hallo @skurfuerst, @beheist, mag sich das mal jemand anschauen?

@skurfuerst
Copy link
Member

@daniellienert was denkst du, müssen wir das mit nem Token absichern; könnte das sonst ne Sicherheitslücke sein?

@daniellienert
Copy link
Contributor

Mir fallen nicht viele Angriffsvektoren ein. Eventuell direktes Umleiten eines Benutzers auf eine Seite mit Schadcode nach dem er sich eingeloggt hat. Was hälst du davon, nur Zieladressen zuzulassen, welche der aktuellen Domain entsprechen?

@skurfuerst
Copy link
Member

@daniellienert das find ich ne gute Idee :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants