-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of the inline powerbox #1398
base: master
Are you sure you want to change the base?
Conversation
5b682ae
to
62e14d8
Compare
It's still a bit rough around the edges, but the basic functionality works.
62e14d8
to
4bf4333
Compare
4bf4333
to
887b698
Compare
.assert.containsText("#request-result", "successfully fetched page"); | ||
}; | ||
|
||
module.exports["Install Faling Inline Powerbox"] = function (browser) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Faling/Failing/
What is this PR in comparison to Sandstorm today, @zenhack? Should this be closed? |
It looks like this is a slightly different feature/design than what sandstorm currently has; if I'm reading the code correctly it shows an input just below the bottom of the grain frame, instead of a modal dialog floating over it. What I don't know is what the intent was here -- were folks expecting to have both UIs for some reason, or is this just obsolete? Is there a design doc somewhere? @kentonv, any thoughts? |
The "inline powerbox" refers to the "autocomplete style" powerbox UI described in the roadmap. I do think this style of powerbox is important in the long term. Many kinds of everyday interactions -- such as selecting recipients of an e-mail -- become cumbersome with a full powerbox, but could be made to feel almost normal using the inline powerbox, without sacrificing security. However, implementing the inline powerbox is pretty hairy, since it requires communication between the app and the shell to capture keystrokes and decide where to render the overlay. I think we should focus on lower-hanging fruit for the time being. |
It's still a bit rough around the edges, but the basic functionality
works.