Add checking of unhandled errors

.golangci.yml

@@ -37,5 +37,3 @@ linters:
     - unused
     - varcheck
     - whitespace
-  disable:
-    - errcheck

rpm/repository.go

@@ -121,7 +121,10 @@ func (r *yumRepository) PackageWithNameAndVersion(name string, version string) (
 		return repos.Package{}, err
 	}
 	var repomd RepoMd
-	xml.Unmarshal(repomdData, &repomd)
+
+	if err = xml.Unmarshal(repomdData, &repomd); err != nil {
+		return repos.Package{}, err
+	}
 
 	filelist := filepath.Join(r.path(), filelist(repomd))
 
@@ -144,7 +147,9 @@ func (r *yumRepository) PackageWithNameAndVersion(name string, version string) (
 
 	var filelistsContent Filelists
 
-	xml.Unmarshal(filelistData, &filelistsContent)
+	if err = xml.Unmarshal(filelistData, &filelistsContent); err != nil {
+		return repos.Package{}, err
+	}
 
 	return findPackageWithVersion(filelistsContent, name, version)
 }

rpm/repository_test.go

@@ -26,7 +26,9 @@ func TestPath(t *testing.T) {
 }
 
 func TestEnsureExists(t *testing.T) {
-	repo.store.ensureExists(repo.name)
+	if _, err := repo.store.ensureExists(repo.name); err != nil {
+		t.Error(err)
+	}
 	file, err := os.Open(path)
 	if err != nil {
 		t.Errorf("%s", err)

rpm/store.go

@@ -24,7 +24,12 @@ func (store *yumRepoStore) Get(name string) repos.AnyRepository {
 
 func (store *yumRepoStore) Initialize(name string) error {
 	log.Printf("Initializing repository %s", name)
-	path := store.ensureExists(name)
+
+	path, err := store.ensureExists(name)
+	if err != nil {
+		return err
+	}
+
 	log.Printf("Executing `createrepo --database %s`", path)
 	cmd := exec.Command("createrepo", "--database", path)
 	return cmd.Run()
@@ -44,11 +49,13 @@ func (store *yumRepoStore) ListRepositories() []repos.Repository {
 	return reps
 }
 
-func (store *yumRepoStore) ensureExists(name string) string {
+func (store *yumRepoStore) ensureExists(name string) (string, error) {
 	path := filepath.Join(store.base, name)
-	if _, err := os.Stat(path); os.IsNotExist(err) {
+
+	_, err := os.Stat(path)
+	if os.IsNotExist(err) {
 		log.Printf("Creating repository directory %s", path)
-		os.MkdirAll(path, 0755)
+		err = os.MkdirAll(path, 0755)
 	}
-	return path
+	return path, err
 }