Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soap-hil: add scorch demo and options to run without hardware #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

soap-hil: add scorch demo and options to run without hardware #9

wants to merge 2 commits into from

Conversation

cmulk
Copy link
Contributor

@cmulk cmulk commented Nov 6, 2024 •
edited
Loading

New additions to soap-hil:

  • Options to run without HIL (ironic)
  • SCORCH pipeline demo including traffic capture, parsing via Zeek, and saving results to elastic

GhostofGoes
GhostofGoes requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor spelling and format issues I found while reading through it.

soap-hil/README.md Outdated Show resolved Hide resolved
soap-hil/README.md Outdated Show resolved Hide resolved
soap-hil/README.md Outdated Show resolved Hide resolved
@GhostofGoes
Copy link
Collaborator

@cmulk LGTM, good to merge if you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhostofGoes GhostofGoes GhostofGoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmulk @GhostofGoes