V2 beta #522
Merged
V2 beta #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2: Remove is() property
v2: Remove find element
v2: remove "multiple" option support
[v2] remove "mutliple" deprecation from finders
v2: group finders
this allows to reduce need for direct `throwBetterError(` usages, and respect initiators stacktrace.
Introduce (private) `action`
In order to set a custom adapter, you can do it globally in global your test
helper, like:
```js
// tests/test-helper.js
import MyAdapter from 'path/to/adapter';
import { setAdapter } from 'ember-cli-page-object/adapters';
setAdapter(new MyAdapter());
```
in case you you need multiple adapters being set for different modules,
make sure to set a teardown it before each test:
```js
hooks.beforeEach(function() {
setAdapter(new MyAdapter());
});
hooks.beforeEach(function() {
setAdapter(null);
});
```
by default, if no adapter set, `RFC268Adapter` is used.
This PR does also introduce few of the old and deprecated
ModuleFor-only related APIs, like:
- `getContext(`
- `setContext(`
- `removeContext(`
- `render(`
- `page.context`
- `useNativeEvents(`
- `andThen` behavior support. Now you have to explicitly wait for the
previous action to complete.
And some APIs that just don't make sense anymore:
- `registerExecutionContext`
promote `getter` as a public way to create custom properties
to have `scope` as an optional argument
Fix/getters signature types
V2/fix action context
types(v2): Allow synthetic default imports
before the change a raw ember error was used, which was not informative enough
Fix visitable error message
…-to-error v2: replace `create-url-argument` deprecation with error
…cation-to-error v2: turn comma-separated-selectors deprecation into error
- update tests to avoid use of string properties - convert affected tests to TS
…error V2/"string-property" deprecation to error
v2: Docs/migration
|
🎉 awesome work @ro0gr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.