Adapters #511
Merged
Adapters #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some work-arounds for old test scenarios. Though in general I'd like to get rid of legacy stuff like |
In order to set a custom adapter, you can do it globally in global your test
helper, like:
```js
// tests/test-helper.js
import MyAdapter from 'path/to/adapter';
import { setAdapter } from 'ember-cli-page-object/adapters';
setAdapter(new MyAdapter());
```
in case you you need multiple adapters being set for different modules,
make sure to set a teardown it before each test:
```js
hooks.beforeEach(function() {
setAdapter(new MyAdapter());
});
hooks.beforeEach(function() {
setAdapter(null);
});
```
by default, if no adapter set, `RFC268Adapter` is used.
This PR does also introduce few of the old and deprecated
ModuleFor-only related APIs, like:
- `getContext(`
- `setContext(`
- `removeContext(`
- `render(`
- `page.context`
- `useNativeEvents(`
- `andThen` behavior support. Now you have to explicitly wait for the
previous action to complete.
And some APIs that just don't make sense anymore:
- `registerExecutionContext`
old ember was supposed to be used with ember-cli-qunit according to the blueprint. Seems like because of old ember + ember-qunit combo, we have some awaiting test issues. This change allows us to get rid of a long living `expect-ember-error` work-around.
instead of relying on eternal waiters. leveraging helpers like `wait`, `andThen`, and `settled` is not reliable across different test frameworks/ember versions. We should focus on testing our public API behavior at the first place.
there is a custom build flow to make the addon-test-support importable from the root of the package. This seems to be a bit more complicated to maintain then it could have been. Maybe exploring the Emberoider land could help us to simplify here.
ro0gr
commented
Dec 28, 2020
tests/acceptance/rfc268-test.js
Outdated
|
|
||
| if (require.has('@ember/test-helpers')) { | ||
| // intentionally not using our local extension in order to make | ||
| // sure, RFC268 works by default, w/o Adapter being set. |
There was a problem hiding this comment.
copy-pasted comment not applicable
While it feels natural to auto-select an offcial RFC268 test mode, if no adapter was specified; it adds some extra internal complexity, because of eager import of the `@ember/test-helpers`. In theory, it's possible to not have `@ember/test-helpers` installed, which is demonstrated in "with-ember-test-helpers" ember-try scenario. To solve this we could use `window.require(`, to lazily import needed helpers, only in case if `@ember/test-helpers` installed. But this aproach may leads to some issues in Node.js envs, since `window.require` is not a thibng there. Also I'm not sure if `window.require(` is supposed to work fine with Emberoider. So, we go an explicit way for now, and require to import, and set a desired adapter on the test suite side manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #479
With this PR we convert private ExecutionContexts to public Adapters.
It's required now to
setAdapterbefore start using page objects in tests:in case you you need multiple adapters being set for different modules,
make sure to set a teardown it before each test:
if no adapter is set, an error throws.
This PR does also remove few of the old and deprecated ModuleFor-only related APIs, like:
And some APIs that just don't make sense anymore: