-
Notifications
You must be signed in to change notification settings - Fork 90
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stop using rfc268 adapter if not set
While it feels natural to auto-select an offcial RFC268 test mode, if no adapter was specified; it adds some extra internal complexity, because of eager import of the `@ember/test-helpers`. In theory, it's possible to not have `@ember/test-helpers` installed, which is demonstrated in "with-ember-test-helpers" ember-try scenario. To solve this we could use `window.require(`, to lazily import needed helpers, only in case if `@ember/test-helpers` installed. But this aproach may leads to some issues in Node.js envs, since `window.require` is not a thibng there. Also I'm not sure if `window.require(` is supposed to work fine with Emberoider. So, we go an explicit way for now, and require to import, and set a desired adapter on the test suite side manually.
- Loading branch information
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters