refactor: simplify re-throw

san650 · Jan 19, 2024 · 24bdee2 · 24bdee2
1 parent affca42
commit 24bdee2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/addon/src/-private/better-errors.js b/addon/src/-private/better-errors.js
@@ -78,6 +78,7 @@ function buildPropertyNamesPath(node) {
     path.unshift(Ceibo.meta(current).key);
   }
 
+  // replace "root" with "page"
   path[0] = 'page';
 
   return path;

diff --git a/addon/src/macros/getter.js b/addon/src/macros/getter.js
@@ -50,13 +50,11 @@ export function getter(fn) {
       } catch (e) {
         if (e instanceof PageObjectError) {
           if (!e.cause.key) {
-            // re-throw with a page object key to have a complete error message
-            const { message, node, selector } = e.cause;
-            const wrapperError = new PageObjectError(message, {
+            // re-throw with a `pageObjectKey` to have a complete error message
+            const wrapperError = new PageObjectError(e.cause.message, {
               cause: {
+                ...e.cause,
                 key: pageObjectKey,
-                node,
-                selector,
               },
             });
             wrapperError.stack = e.stack;