Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for UI and Routing Issues in Eventmint #499

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

himanshumishra1309
Copy link
Contributor

This pull request addresses the issues I raised previously regarding UI inconsistencies and routing errors in [App Name]. I have provided detailed explanations of each fix below, along with the solutions implemented to ensure a smoother user experience.

Issues Fixed:

1] Header Update Issue

  • Problem: The header was not updating correctly when navigating between sections ("Play," "Sports Activities," "List Your Shows," "Offers," "Gift Cards"). Both "Movies" and the current section were highlighted simultaneously, which could confuse users.

  • Solution: I modified the header component logic to ensure that only the currently active section is highlighted. Now, the navigation state updates dynamically as users switch between sections, highlighting only the section they’re viewing.

2] Broken Routes

  • Problem: The routes:
    /stream-events
    /corporates
    were displaying blank pages, causing confusion for users.

  • Solution: I added conditional rendering for these routes. If a route is still under development or unavailable, it now displays a “Page under construction” alert, letting users know the route is intentionally unavailable rather than indicating a loading or connection error.

3] Inconsistent Card Sizes on "Play" Route

  • Problem: The cards displayed under the "Play" route lacked uniform sizing, creating an uneven look.
  • Solution: I adjusted the CSS styling for these cards to ensure uniform height, width, and spacing, resulting in a more polished and consistent display.

I have thoroughly tested each fix across different screen sizes and on both desktop and mobile devices to ensure compatibility and a consistent user experience. Each update aligns with the project’s design standards and improves the overall usability of the app.

I'm skilled in MERN and happy to assist with any backend tasks as well if needed. Feel free to reach out via LinkedIn if you'd like further collaboration: LinkedIn Profile.

Please review the changes, and let me know if any adjustments are needed to align with the project’s code standards. I’m open to feedback and willing to make refinements as required.

… now the part which is active only that is highlighted and have added an alert in the stream event and corporates part saying that part of the website is not yet ready
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eventmint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 7:04am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Eventmint team will review it as soon as possible. We appreciate your support in making this project better

@samyakmaitre samyakmaitre added gssoc-ext Under GSSOC'24 Extended hacktoberfest-accepted Hacktoberfest'24 level2 Under GSSOC'24 Extended labels Nov 10, 2024
@samyakmaitre samyakmaitre merged commit d5ff7c7 into samyakmaitre:main Nov 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Under GSSOC'24 Extended hacktoberfest-accepted Hacktoberfest'24 level2 Under GSSOC'24 Extended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants