Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #2390

Merged
merged 10 commits into from
Nov 27, 2024
Merged

UI improvements #2390

merged 10 commits into from
Nov 27, 2024

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Nov 26, 2024

Summary

Some collection changes were not contributed back from pals. This contributes the collection show page back to Hyku from Pals, and fine-tunes some collection CSS. It also removes some metadata-based css which was too limiting, since collection metadata is fluid.

The collection masonry view has not yet been addressed.

Refs:

Additionally, it fixes a bug in the recent documents links on the default homepage.

Screenshots

Collection show page with list view

screencapture-cat-hyku-test-collections-57abb80a-db5f-453a-98fd-d348c0d9151d-2024-11-25-20_07_36

Recent documents on default home page

Screenshot 2024-11-26 at 11 29 08 AM

@samvera/hyku-code-reviewers

@laritakr laritakr added the minor-ver for release notes label Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Test Results

    3 files  ±0      3 suites  ±0   18m 8s ⏱️ +28s
2 053 tests ±0  2 003 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 080 runs  ±0  2 028 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit e1fa767. ± Comparison against base commit d427e24.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 0671350d-74a2-4af2-8063-a0a9a57dc1f5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit bd715a66-be0e-4871-b981-807922741da1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read d283d090-3dd2-4c60-b404-a38103eb0dfc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 23a4498a-8225-4c2a-aa05-2cbc90cb0bb3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5cbf39d5-891f-4df5-bdec-413c3e89cf33
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f89ab5b0-b969-40eb-b1fa-30dfe4f016f0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 0fb31c43-3879-43ee-bb0f-a2769b1aeeb9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c00a78b6-efc9-448e-8b90-e54ea1e393f6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 93671768-ef7e-48b4-9c60-a9c2f485f4c5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 51213fac-910f-4dd0-8920-bce440549b84
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 7ad04a00-ba12-41ae-8d3e-a2a90cc8a0f3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a9848dfd-f817-467f-92c7-222223791716
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4d8ef538-bbdc-45be-8c8f-203829bb2372
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 92552a24-81e8-4512-aaf3-91747c392273
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 59f87fbd-5dae-4d41-8053-5121a5a18ea6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9a7f9e4c-e02d-4028-b7bd-1cbfdbcaa465
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read bf5282f0-4c20-4610-8d7a-7ae42ffb7c6b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update cbcb2be3-0481-4b2a-b9f5-4d0fe48152ed
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy d08da055-2575-4555-9e4e-5967996d5039
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 56ce0277-6319-431a-9167-4a5535496b35
…

♻️ This comment has been updated with latest results.

@laritakr laritakr merged commit f76a5d5 into main Nov 27, 2024
8 checks passed
@laritakr laritakr deleted the move-code-from-pals branch November 27, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants