-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements #2390
Merged
Merged
UI improvements #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicators default to true... not loading them prevented branding.
Added "Other"
Test Results 3 files ±0 3 suites ±0 18m 8s ⏱️ +28s Results for commit e1fa767. ± Comparison against base commit d427e24. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
aprilrieger
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some collection changes were not contributed back from pals. This contributes the collection show page back to Hyku from Pals, and fine-tunes some collection CSS. It also removes some metadata-based css which was too limiting, since collection metadata is fluid.
The collection masonry view has not yet been addressed.
Refs:
Additionally, it fixes a bug in the recent documents links on the default homepage.
Screenshots
Collection show page with list view
Recent documents on default home page
@samvera/hyku-code-reviewers