Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New account setting to override Bulkrax's default split pattern #2380

Closed
wants to merge 1 commit into from

new account setting to override Bulkrax's split pattern

0f27e3b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

New account setting to override Bulkrax's default split pattern #2380

new account setting to override Bulkrax's split pattern
0f27e3b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results failed Nov 12, 2024 in 0s

2 fail, 50 skipped, 1 988 pass in 18m 21s

    3 files      3 suites   18m 21s ⏱️
2 040 tests 1 988 ✅ 50 💤 2 ❌
2 067 runs  2 013 ✅ 52 💤 2 ❌

Results for commit 0f27e3b.

Annotations

Check warning on line 0 in ./spec/jobs/migrate_resources_job_spec.rb

See this annotation in the file changed.

@github-actions github-actions / Test Results

MigrateResourcesJob#perform migrates a file set by its id (spec.jobs.migrate_resources_job_spec) failed 

artifacts/spec-reports-0/rspec-0.xml [took 0s]
Raw output 
expected `nil.present?` to be truthy, got false
Failure/Error: expect(Valkyrie::Persistence::Postgres::ORM::Resource.find_by(id: af_file_set.id.to_s)).to be_present
  expected `nil.present?` to be truthy, got false
./spec/jobs/migrate_resources_job_spec.rb:41:in `block (3 levels) in <top (required)>'
./spec/support/multitenancy_metadata.rb:50:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/webmock-3.19.1/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'

Check warning on line 0 in ./spec/models/concerns/account_settings_spec.rb

See this annotation in the file changed.

@github-actions github-actions / Test Results

AccountSettings#public_settings when is_superadmin is true returns all settings except private and disabled settings (spec.models.concerns.account_settings_spec) failed 

artifacts/spec-reports-1/rspec-1.xml [took 0s]
Raw output 
 expected: [:allow_downloads, :allow_signup, :analytics_provider, :cache_api, :contact_email, :contact_email_to,...efix, :oai_sample_identifier, :s3_bucket, :smtp_settings, :solr_collection_options, :ssl_configured]      got: [:allow_downloads, :allow_signup, :analytics_provider, :bulkrax_split_pattern, :cache_api, :contact_e...efix, :oai_sample_identifier, :s3_bucket, :smtp_settings, :solr_collection_options, :ssl_configured]  (compared using ==)  Diff: @@ -1,6 +1,7 @@  [:allow_downloads,   :allow_signup,   :analytics_provider, + :bulkrax_split_pattern,   :cache_api,   :contact_email,   :contact_email_to,
Failure/Error:
  expect(account.public_settings(is_superadmin: true).keys.sort).to eq %i[allow_downloads
                                                                          allow_signup
                                                                          analytics_provider
                                                                          cache_api
                                                                          contact_email
                                                                          contact_email_to
                                                                          doi_reader
                                                                          doi_writer
                                                                          email_domain
                                                                          email_format

  expected: [:allow_downloads, :allow_signup, :analytics_provider, :cache_api, :contact_email, :contact_email_to,...efix, :oai_sample_identifier, :s3_bucket, :smtp_settings, :solr_collection_options, :ssl_configured]
       got: [:allow_downloads, :allow_signup, :analytics_provider, :bulkrax_split_pattern, :cache_api, :contact_e...efix, :oai_sample_identifier, :s3_bucket, :smtp_settings, :solr_collection_options, :ssl_configured]

  (compared using ==)

  Diff:
  @@ -1,6 +1,7 @@
   [:allow_downloads,
    :allow_signup,
    :analytics_provider,
  + :bulkrax_split_pattern,
    :cache_api,
    :contact_email,
    :contact_email_to,
./spec/models/concerns/account_settings_spec.rb:10:in `block (4 levels) in <top (required)>'
./spec/support/multitenancy_metadata.rb:50:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/webmock-3.19.1/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:124:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.2/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
View more details on GitHub Actions