Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i51 - reverts accidental delete #2261

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Jun 27, 2024

In PR#2236 we accidentally deleted the word as from the view.

ref:

BEFORE

image

AFTER

image

In PR#2236 we accidentally deleted the word as from the view.

ref:
- https://github.com/samvera/hyku/pull/2236/files
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Jun 27, 2024
@ShanaLMoore ShanaLMoore changed the title i51 - revert accidental delete i51 - reverts accidental delete Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 34s ⏱️ +3s
2 027 tests ±0  1 976 ✅  - 1  50 💤 ±0  1 ❌ +1 
2 054 runs  ±0  2 001 ✅  - 1  52 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 8a0945c. ± Comparison against base commit e7ac989.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 61f8a8c7-62e2-4c8a-9e02-6aa84e9d80bb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e15e2a75-26cb-487b-af8c-1fec94076a3f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 09b8a37e-d7c1-4710-989f-2a80e5b57735
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1b3bc16d-d8b5-4048-90f4-490e191186da
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 541fbf95-5ff0-43eb-a3ee-74949af7d329
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 43f19f0f-a765-410d-b6a9-8c140bfec7e3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3e8748c2-8317-470b-ad7e-1a01e0d981a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 4827733f-23d3-4b94-a40c-3c06828a78a4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 06864e16-a926-4ff8-bfc2-f7112f815433
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b0eeb7ad-feea-4cce-9d92-32f1777d115e
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy feaee97a-f2f6-42d6-a34e-fa221c009ea2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3a9632e4-0fff-4c3d-81a8-ac1d9a48c100
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read bd3ca0af-3998-47fb-84cb-f2c02cbeb272
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update a5d780ad-18e0-43ce-9aac-8679e98f3531
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 0f55ad28-cef2-48d2-a9cd-450aa52525c6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 2e7cebc0-f32f-4e9f-b39b-a1bda88bca94
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 92a1a72c-08e6-4e5b-bfed-adbb0275047f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 57020bb2-5fa5-40db-87a8-f119febd762d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy d1b1b344-78fc-4cc2-9bfa-00c6d5d34e04
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 3f35622e-87e9-4dba-aa68-9e0c686c6c91
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore marked this pull request as draft June 27, 2024 20:25
@ShanaLMoore ShanaLMoore marked this pull request as ready for review June 27, 2024 22:59
@ShanaLMoore ShanaLMoore requested review from kirkkwang and removed request for kirkkwang July 2, 2024 16:11
@ShanaLMoore ShanaLMoore marked this pull request as draft July 2, 2024 16:12
kirkkwang
kirkkwang previously approved these changes Jul 2, 2024
@ShanaLMoore
Copy link
Collaborator Author

@ShanaLMoore ShanaLMoore marked this pull request as ready for review July 3, 2024 15:14
@ShanaLMoore ShanaLMoore merged commit f7e9a0d into main Jul 3, 2024
8 of 10 checks passed
@ShanaLMoore ShanaLMoore deleted the i51-replace-as-word-in-view branch July 3, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants