add blacklight advances search, blacklight date ranges and order already #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady to the gem file and configure them
houndci-bot
reviewed
Sep 21, 2023
houndci-bot
reviewed
Sep 21, 2023
houndci-bot
reviewed
Sep 21, 2023
houndci-bot
reviewed
Sep 21, 2023
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
houndci-bot
reviewed
Sep 21, 2023
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| global.BlacklightRangeLimit = BlacklightRangeLimit; | ||
| }(this); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
houndci-bot
reviewed
Sep 21, 2023
app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
|
|
||
| var min = max = BlacklightRangeLimit.parseNum(current_limit.find(".single").text()) |
There was a problem hiding this comment.
Missing semicolon.
You might be leaking a variable (max) here.
app/assets/javascripts/blacklight_range_limit/range_limit_slider.js
Outdated
Show resolved
Hide resolved
|
|
||
| if (plot && slider_el) { | ||
| slider_el.width(plot.width()); | ||
| slider_el.css("display", "block") |
| placeholder_input.slider("setValue", values); | ||
| }); | ||
|
|
||
| end_el.change( function() { |
| begin_el.val(min); | ||
| end_el.val(max); | ||
|
|
||
| begin_el.change( function() { |
houndci-bot
reviewed
Sep 21, 2023
| } | ||
|
|
||
| begin_el.val(min); | ||
| end_el.val(max); |
| }); | ||
| } | ||
|
|
||
| begin_el.val(min); |
|
|
||
| // Slider change should update text input values. | ||
| var parent = $(this).parent(); | ||
| var form = $(parent).closest(".limit_content").find("form.range_limit"); |
|
|
||
| if (plot && slider_el) { | ||
| slider_el.width(plot.width()); | ||
| slider_el.css("display", "block") |
app/assets/javascripts/blacklight_range_limit/range_limit_slider.js
Outdated
Show resolved
Hide resolved
The previous build revealed that admin_color_select.js was missing. It also complained about missing semicolons.
appease the hound by formatting js file with semicolons.
houndci-bot
reviewed
Sep 25, 2023
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
houndci-bot
reviewed
Sep 25, 2023
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
houndci-bot
reviewed
Sep 25, 2023
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
Cause of build error. It's already being included in sass.
This commit will add additional setup to the catalog_controller_spec.
|
I attempted to test this from hyku proper since adventist knapsack currently can't create works. I see the date range facet displayed but entering dates creates an error:
|
…mvera/hyku into blacklight_advanced_and_range
|
added with a different merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the gem file and configure them